Buchanan was a highly respected lawyer who built an impressive practice in Lancaster. He handled estates, family law cases, and property claims. He also defended several prominent politicians in legal matters. For example, he successfully defended Judge Walter Franklin in an impeachment proceeding before the Pennsylvania state Senate. Jean H. Baker in her biography James Buchanan in the American Presidents Series writes that he became “one of the best known lawyers in southern Pennsylvania.”